Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Login] password reset page- missing element import #9171

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

kongtiaowang
Copy link
Contributor

@kongtiaowang kongtiaowang commented Mar 27, 2024

Brief summary of changes

StaticElement
#9143
[login] Update password page still accessible with expired one-time password #9144

Testing instructions (if applicable)

Testing reset password page and submitting two mismatching passwords, it will show the error, not the blank page.

@kongtiaowang kongtiaowang added the 26.0.0-bugs Issues that were raised during the release testing for 26.0.0 label Mar 27, 2024
@regisoc regisoc self-assigned this Apr 4, 2024
Copy link
Contributor

@regisoc regisoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on my VM.

  • Error raised when mismatching passwords in the "change password page", no redirection to a blank page.
    image
  • Cannot re-use an already used one-time password.

@driusan driusan merged commit c8c0ddb into aces:main Apr 4, 2024
28 checks passed
@ridz1208 ridz1208 added this to the 26.0.0 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
26.0.0-bugs Issues that were raised during the release testing for 26.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants