Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[document_repository] Uploading file too large not reporting correctly #9158 - fix #9174

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

kongtiaowang
Copy link
Contributor

Brief summary of changes

[document_repository] Uploading file too large not reporting correctly #9158

Testing instructions (if applicable)

upload a large file more than 1 GB, it will popup a error message "file too large"
截屏2024-03-27 上午10 36 00

@kongtiaowang kongtiaowang added the 26.0.0-bugs Issues that were raised during the release testing for 26.0.0 label Mar 27, 2024
@regisoc regisoc self-assigned this Apr 4, 2024
Copy link
Contributor

@regisoc regisoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Shen, thanks for this PR.

I cannot see the "File too large" window appearing.
When trying to send a 5+GB file, I still have this error log:

[Thu Apr 04 10:45:44.134866 2024] [php:warn] [pid 17999] [client ::1:56220] PHP Warning:  POST Content-Length of 5214864626 bytes exceeds the limit of 8388608 bytes in Unknown on line 0, referer: http://localhost:8080/document_repository/

JS console log:
image

@driusan
Copy link
Collaborator

driusan commented Apr 4, 2024

There are 2 related php.ini settings that affect the maximum size (I can't remember the settings off the top of my head, but they should be in the documentation.) It's possible that the code is checking one but not the other.

@regisoc
Copy link
Contributor

regisoc commented Apr 4, 2024

Still having the same error after applying these config.

@kongtiaowang
Copy link
Contributor Author

kongtiaowang commented Apr 9, 2024

@regis Could you try to upload a 2GB file to test the popup window? It seems like you got the network issue(Chrome) when you upload a 5 GB file.

@regisoc
Copy link
Contributor

regisoc commented Apr 9, 2024

@kongtiaowang I will try that. Is the issue on Chrome based browsers? I am mostly using Firefox.

@regisoc
Copy link
Contributor

regisoc commented Apr 9, 2024

Same error on Firefox with ~1.9GB archive file.
Log:

[Tue Apr 09 10:09:41.989971 2024] [php:warn] [pid 1402] [client ::1:47224] PHP Warning:  POST Content-Length of 2093357522 bytes exceeds the limit of 1073741824 bytes in Unknown on line 0, referer: http://localhost:8080/document_repository/

image

@regisoc
Copy link
Contributor

regisoc commented Apr 9, 2024

Tested with the same file on 26.0 vm with firefox. Looks ok on it.
image

Copy link
Contributor

@regisoc regisoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shen and I tested this on 2 VMs.
I had some issues with my config because of the SSH tunnel, it seems.
Using my VM through SSH tunnel raise the error, but using it with the VPN does not.

@driusan driusan merged commit d21ecde into aces:main Apr 11, 2024
28 checks passed
@ridz1208 ridz1208 added this to the 26.0.0 milestone Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
26.0.0-bugs Issues that were raised during the release testing for 26.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants