Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[notification] Fix sender name in email #9203

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

maximemulder
Copy link
Contributor

Brief summary of changes

Display the name of the user instead of their ID in the notification emails.

Testing instructions

  1. Trigger an email notification which displays the sender name in the email (such as media file upload).

Link(s) to related issue(s)

@maximemulder
Copy link
Contributor Author

maximemulder commented Apr 11, 2024

I still haven't looked at why I get linting errors in files I haven't touched, but I imagine that shouldn't be a blocker ?

EDIT : Surprisingly, the linter seems to be happy here while it was unhappy on my VM 🤔.

@driusan driusan merged commit e96d5a8 into aces:main Apr 16, 2024
28 checks passed
@ridz1208 ridz1208 added this to the 26.0.0 milestone Jun 6, 2024
@maximemulder maximemulder deleted the fix-notification-email-sender branch October 29, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[notification] Notification email sender name incorrect
4 participants