[dataquery/dictionary] Add option to display enums as either value or field in dataquery module #9224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an option in the data query tool to display Enum data types as either a field value or the human readable field label.
driusan
force-pushed
the
EnumDisplayOption
branch
from
edf9e3f
to
35d8633
Compare
regisoc
reviewed
May 2, 2024
Comment on lines
+76
to
+87
| switch (props.enumDisplay) { | ||
| case EnumDisplayTypes.EnumLabel: | ||
| if (props.dictionary.labels && props.dictionary.options) { | ||
| for (let i = 0; i < props.dictionary.options.length; i++) { | ||
| if (props.dictionary.options[i] == props.value) { | ||
| display= props.dictionary.labels[i]; | ||
| break; | ||
| } | ||
| } | ||
| } | ||
| break; | ||
| } |
There was a problem hiding this comment.
Do we expect other cases in the future for enum?
Just wondering why the switch-case with only one option.
There was a problem hiding this comment.
I think I started with both values then realized the EnumValue option didn't actually need any code.. but I think it's also possible people will ask for other cases at some point.
regisoc
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dataquery module was showing the backend enum value, rather than the frontend label, which isn't very useful to most users.
This adds an option for the user to select how they want to display enums.
It also updates the menu label from "alpha" to "beta" since the module has now been tested with large data sets.