-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EEG] Montage color map #9273
Merged
Merged
[EEG] Montage color map #9273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laemtl
added
the
Needs Work
PR awaiting additional changes by the author or contains issues that the author needs to fix
label
May 17, 2024
@christinerogers @jeffersoncasimir For visibility |
jeffersoncasimir
approved these changes
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected!
jeffersoncasimir
added
the
Passed Manual Tests
PR has undergone proper testing by at least one peer
label
May 30, 2024
laemtl
removed
the
Needs Work
PR awaiting additional changes by the author or contains issues that the author needs to fix
label
May 30, 2024
@ridz1208 Ready |
amazing, thanks team. could we get a merge for the release? |
This doesn't have any description. What is it doing and why? |
@driusan done |
maximemulder
pushed a commit
to maximemulder/Loris
that referenced
this pull request
Sep 25, 2024
Add a colormap to flag specific channels in the EEG montage To use it, the code must be modified to add the indexes before compiling. ie in modules/electrophysiology_browser/jsx/electrophysiologySessionView.js add: ``` <EEGMontage colorMap={ { color: '#FF0000', ids: [1,2,4,7] // index of electrodes to include in the colorMap } } /> ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a colormap to flag specific channels in the EEG montage:
To enable it, add the following in In
modules/electrophysiology_browser/jsx/electrophysiologySessionView.js