Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EEG] Montage color map #9273

Merged
merged 2 commits into from
Jun 4, 2024
Merged

[EEG] Montage color map #9273

merged 2 commits into from
Jun 4, 2024

Conversation

laemtl
Copy link
Contributor

@laemtl laemtl commented May 17, 2024

Add a colormap to flag specific channels in the EEG montage:

Screenshot 2024-06-04 at 10 04 26 AM

To enable it, add the following in In modules/electrophysiology_browser/jsx/electrophysiologySessionView.js

<EEGMontage colorMap={
    { 
      color: '#FF0000',
      ids: [1,2,4,7] // index of electrodes to include in the colorMap
    }
 } />

@laemtl laemtl added the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label May 17, 2024
@laemtl
Copy link
Contributor Author

laemtl commented May 17, 2024

@christinerogers @jeffersoncasimir For visibility

Copy link
Contributor

@jeffersoncasimir jeffersoncasimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

@jeffersoncasimir jeffersoncasimir added the Passed Manual Tests PR has undergone proper testing by at least one peer label May 30, 2024
@laemtl laemtl removed the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label May 30, 2024
@laemtl
Copy link
Contributor Author

laemtl commented May 30, 2024

@ridz1208 Ready

@christinerogers
Copy link
Contributor

christinerogers commented May 30, 2024

amazing, thanks team. could we get a merge for the release?

@driusan
Copy link
Collaborator

driusan commented Jun 3, 2024

This doesn't have any description. What is it doing and why?

@laemtl
Copy link
Contributor Author

laemtl commented Jun 4, 2024

@driusan done

@driusan driusan merged commit 55122f9 into aces:main Jun 4, 2024
28 checks passed
@ridz1208 ridz1208 added this to the 26.0.0 milestone Jun 6, 2024
maximemulder pushed a commit to maximemulder/Loris that referenced this pull request Sep 25, 2024
Add a colormap to flag specific channels in the EEG montage

To use it, the code must be modified to add the indexes before compiling.

ie in modules/electrophysiology_browser/jsx/electrophysiologySessionView.js add:

```
<EEGMontage colorMap={
    { 
      color: '#FF0000',
      ids: [1,2,4,7] // index of electrodes to include in the colorMap
    }
 } />
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants