Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tools] Refactor recreate_conflicts.php to use getInstrumentNamesList() #9280

Merged
merged 1 commit into from
Jun 3, 2024
Merged

[tools] Refactor recreate_conflicts.php to use getInstrumentNamesList() #9280

merged 1 commit into from
Jun 3, 2024

Conversation

ay-bh
Copy link
Collaborator

@ay-bh ay-bh commented May 25, 2024

Brief summary of changes

Refactored recreate_conflicts.php to replace the deprecated Utility::getAllInstruments() function with NDB_BVL_Instrument::getInstrumentNamesList($lorisInstance)

Testing instructions (if applicable)

  1. Navigate to /var/www/loris/tools.
  2. Run the script with the command php recreate_conflicts.php all.
  3. Verify that the script runs without the deprecation error and correctly retrieves all instrument names.

Link(s) to related issue(s)

@racostas racostas self-requested a review May 28, 2024 01:26
racostas
racostas approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@racostas
Copy link
Contributor

@ridz1208 , @driusan, this one looks good to me. I think could be valuable for loris 26 if we have time yet.
I leave the final review/approval to you.

@ay-bh is one of our new GSoC student (tagging @christinerogers). This it his first PR to our repo. Next time he will make the PR from a different branch that main (it is my fault here since I forgot to mention this convention to him).

Thanks.

@racostas racostas added the Passed Manual Tests PR has undergone proper testing by at least one peer label May 28, 2024
@ridz1208 ridz1208 assigned shonibare and unassigned shonibare May 28, 2024
@driusan driusan merged commit a54468d into aces:main Jun 3, 2024
28 checks passed
@racostas racostas added the 26.0.0-bugs Issues that were raised during the release testing for 26.0.0 label Jun 4, 2024
@ridz1208 ridz1208 added this to the 26.0.0 milestone Jun 6, 2024
maximemulder pushed a commit to maximemulder/Loris that referenced this pull request Sep 25, 2024
@ay-bh @maximemulder
Refactor recreate_conflicts.php to use getInstrumentNamesList() (aces…
c3e5524 
…#9280)

Refactored recreate_conflicts.php to replace the deprecated Utility::getAllInstruments() function with NDB_BVL_Instrument::getInstrumentNamesList($lorisInstance) 

Resolves aces#9267
maximemulder pushed a commit to maximemulder/Loris that referenced this pull request Oct 10, 2024
@ay-bh @maximemulder
Refactor recreate_conflicts.php to use getInstrumentNamesList() (aces…
7d5abe0 
…#9280)

Refactored recreate_conflicts.php to replace the deprecated Utility::getAllInstruments() function with NDB_BVL_Instrument::getInstrumentNamesList($lorisInstance) 

Resolves aces#9267
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@racostas racostas racostas approved these changes

Assignees
No one assigned
Labels
26.0.0-bugs Issues that were raised during the release testing for 26.0.0 Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Milestone
26.0.0
Development

Successfully merging this pull request may close these issues.

Deprecated LORIS function call in recreate_conflicts.php script
5 participants
@ay-bh @racostas @driusan @ridz1208 @shonibare