Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[imaging_uploader] Make auto-launch info popup modal #9287

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

nicolasbrossard
Copy link
Contributor

When config option ImagingUploaderAutoLaunch is on and you successfully upload a scan, there is a popup that appears indicating that the MRI pipeline has been launched in order to process the scan. This PR makes the popup modal (i.e user has to click Ok for the popup to disappear).

Fixes #9286

@nicolasbrossard nicolasbrossard added 26.0.0-bugs Issues that were raised during the release testing for 26.0.0 Area: UI PR or issue related to the user Interface labels May 30, 2024
@regisoc regisoc self-assigned this May 30, 2024
Copy link
Contributor

@regisoc regisoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my VM, swal stays on screen until the user clicks "ok" or outside the modal.

@driusan driusan merged commit f9f12be into aces:main Jun 3, 2024
28 checks passed
@ridz1208 ridz1208 added this to the 26.0.0 milestone Jun 6, 2024
maximemulder pushed a commit to maximemulder/Loris that referenced this pull request Sep 25, 2024
When config option ImagingUploaderAutoLaunch is on and you successfully upload a scan, there is a popup that appears indicating that the MRI pipeline has been launched in order to process the scan. This makes the popup modal (i.e user has to click Ok for the popup to disappear).

Fixes aces#9286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
26.0.0-bugs Issues that were raised during the release testing for 26.0.0 Area: UI PR or issue related to the user Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[imaging_uploader] Information popup disappears when auto-launch is on
4 participants