Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EEG Uploader] User messaging and Documentation update #9296

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

laemtl
Copy link
Contributor

@laemtl laemtl commented Jun 7, 2024

Documentation patch to resolve #9293.

Let users and admins know that they will encounter a known issue (#9191), not a bug with their setup:

This does this by:

  • Adding text visible to Users at the top of the module
  • Adding README message
  • Adding Help text note for users

This does not resolve #9191, but it clarifies the state for LORIS users.

@laemtl laemtl changed the base branch from main to 26.0-release June 7, 2024 15:06
@christinerogers christinerogers changed the title [EEG Uploader] Documentation update [EEG Uploader] User messaging and Documentation update Jun 7, 2024
@christinerogers christinerogers added 26.0.0-bugs Issues that were raised during the release testing for 26.0.0 Documentation PR or issue introducing/requiring modifications to the code documentation (test plans, wikis, docs) Critical to release PR or issue is key for the release to which it has been assigned labels Jun 7, 2024
@laemtl laemtl force-pushed the EEG-uplaoder-documentation-update branch 4 times, most recently from 050f499 to d562b0f Compare June 7, 2024 17:20
@christinerogers christinerogers added Add to Release Notes PR change should be highlighted in Release notes (important security, features and bugfixes) Passed Manual Tests PR has undergone proper testing by at least one peer labels Jun 7, 2024
Copy link
Contributor

@jeffersoncasimir jeffersoncasimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text approved and works as expected!

@laemtl laemtl force-pushed the EEG-uplaoder-documentation-update branch from d562b0f to 7ca4d2b Compare June 7, 2024 18:00
@driusan
Copy link
Collaborator

driusan commented Jun 7, 2024

@laemtl since I can't update the commit message with the merge queue on this branch can you please update the pull request description to describe the change in a way that's suitable for a commit message. (Third person, no images, no checklists, describe what's being done and why.)

@christinerogers
Copy link
Contributor

christinerogers commented Jun 9, 2024

@laemtl since I can't update the commit message with the merge queue on this branch can you please update the pull request description to describe the change in a way that's suitable for a commit message. (Third person, no images, no checklists, describe what's being done and why.)

@driusan just made these changes. Ready for your re-review to merge.

please tag @christinerogers and @laemtl if you see any reason not to merge before the Loris meeting - thanks!

@driusan driusan enabled auto-merge June 10, 2024 13:02
Copy link
Collaborator

@driusan driusan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jefferson already approved it but there was a commit added since then, need to re-approve to trigger merge queue.

@driusan driusan added this pull request to the merge queue Jun 10, 2024
Merged via the queue into aces:26.0-release with commit 2334ba6 Jun 10, 2024
28 checks passed
@ridz1208 ridz1208 added this to the 26.0.0 milestone Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
26.0.0-bugs Issues that were raised during the release testing for 26.0.0 Add to Release Notes PR change should be highlighted in Release notes (important security, features and bugfixes) Critical to release PR or issue is key for the release to which it has been assigned Documentation PR or issue introducing/requiring modifications to the code documentation (test plans, wikis, docs) Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants