-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EEG Uploader] User messaging and Documentation update #9296
[EEG Uploader] User messaging and Documentation update #9296
Conversation
050f499
to
d562b0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text approved and works as expected!
d562b0f
to
7ca4d2b
Compare
@laemtl since I can't update the commit message with the merge queue on this branch can you please update the pull request description to describe the change in a way that's suitable for a commit message. (Third person, no images, no checklists, describe what's being done and why.) |
@driusan just made these changes. Ready for your re-review to merge. please tag @christinerogers and @laemtl if you see any reason not to merge before the Loris meeting - thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jefferson already approved it but there was a commit added since then, need to re-approve to trigger merge queue.
Documentation patch to resolve #9293.
Let users and admins know that they will encounter a known issue (#9191), not a bug with their setup:
This does this by:
This does not resolve #9191, but it clarifies the state for LORIS users.