fix: Fix default feast apply path without any extras (feast-dev#2373)

* fix: Fix default feast apply path without any extras Signed-off-by: Danny Chiao <danny@tecton.ai> * revert removing ge Signed-off-by: Danny Chiao <danny@tecton.ai> Signed-off-by: Achal Shah <achals@gmail.com>
achals · Mar 8, 2022 · 6c8cb53 · 6c8cb53
1 parent 2640cd8
commit 6c8cb53
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 12 deletions.
diff --git a/docs/reference/data-sources/spark.md b/docs/reference/data-sources/spark.md
@@ -13,7 +13,9 @@ The spark data source API allows for the retrieval of historical feature values
 Using a table reference from SparkSession(for example, either in memory or a Hive Metastore)
 
 ```python
-from feast import SparkSource
+from feast.infra.offline_stores.contrib.spark_offline_store.spark_source import (
+    SparkSource,
+)
 
 my_spark_source = SparkSource(
     table="FEATURE_TABLE",
@@ -23,7 +25,9 @@ my_spark_source = SparkSource(
 Using a query
 
 ```python
-from feast import SparkSource
+from feast.infra.offline_stores.contrib.spark_offline_store.spark_source import (
+    SparkSource,
+)
 
 my_spark_source = SparkSource(
     query="SELECT timestamp as ts, created, f1, f2 "
@@ -34,7 +38,9 @@ my_spark_source = SparkSource(
 Using a file reference
 
 ```python
-from feast import SparkSource
+from feast.infra.offline_stores.contrib.spark_offline_store.spark_source import (
+    SparkSource,
+)
 
 my_spark_source = SparkSource(
     path=f"{CURRENT_DIR}/data/driver_hourly_stats",

diff --git a/sdk/python/feast/__init__.py b/sdk/python/feast/__init__.py
@@ -3,9 +3,6 @@
 from pkg_resources import DistributionNotFound, get_distribution
 
 from feast.infra.offline_stores.bigquery_source import BigQuerySource
-from feast.infra.offline_stores.contrib.spark_offline_store.spark_source import (
-    SparkSource,
-)
 from feast.infra.offline_stores.file_source import FileSource
 from feast.infra.offline_stores.redshift_source import RedshiftSource
 from feast.infra.offline_stores.snowflake_source import SnowflakeSource
@@ -50,5 +47,4 @@
     "RedshiftSource",
     "RequestFeatureView",
     "SnowflakeSource",
-    "SparkSource",
 ]
diff --git a/sdk/python/feast/feature_store.py b/sdk/python/feast/feature_store.py
@@ -42,7 +42,6 @@
 from feast.data_source import DataSource
 from feast.diff.infra_diff import InfraDiff, diff_infra_protos
 from feast.diff.registry_diff import RegistryDiff, apply_diff_to_registry, diff_between
-from feast.dqm.profilers.ge_profiler import GEProfiler
 from feast.entity import Entity
 from feast.errors import (
     EntityNotFoundException,
@@ -890,7 +889,6 @@ def create_saved_dataset(
         storage: SavedDatasetStorage,
         tags: Optional[Dict[str, str]] = None,
         feature_service: Optional[FeatureService] = None,
-        profiler: Optional[GEProfiler] = None,
     ) -> SavedDataset:
         """
             Execute provided retrieval job and persist its outcome in given storage.

diff --git a/sdk/python/feast/inference.py b/sdk/python/feast/inference.py
@@ -8,7 +8,6 @@
     FileSource,
     RedshiftSource,
     SnowflakeSource,
-    SparkSource,
 )
 from feast.data_source import DataSource, RequestDataSource
 from feast.errors import RegistryInferenceFailure
@@ -87,8 +86,10 @@ def update_data_sources_with_inferred_event_timestamp_col(
         ):
             # prepare right match pattern for data source
             ts_column_type_regex_pattern = ""
-            if isinstance(data_source, FileSource) or isinstance(
-                data_source, SparkSource
+            # TODO(adchia): Move Spark source inference out of this logic
+            if (
+                isinstance(data_source, FileSource)
+                or "SparkSource" == data_source.__class__.__name__
             ):
                 ts_column_type_regex_pattern = r"^timestamp"
             elif isinstance(data_source, BigQuerySource):