fix: total change percent miscalculation

achannarasappa · Mar 7, 2021 · 254cb01 · 254cb01
1 parent 005b930
commit 254cb01
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/internal/position/position.go b/internal/position/position.go
@@ -106,12 +106,14 @@ func GetPositions(ctx c.Context, aggregatedLots map[string]AggregatedLot) func([
 
 		positionsReduced := getPositionsReduced(ctx, aggregatedLots, quotes)
 
+		change := positionsReduced.positionSummaryBase.value - positionsReduced.positionSummaryBase.cost
+
 		positionSummary := PositionSummary{
 			Value:            positionsReduced.positionSummaryBase.value,
 			Cost:             positionsReduced.positionSummaryBase.cost,
 			Change:           positionsReduced.positionSummaryBase.value - positionsReduced.positionSummaryBase.cost,
 			DayChange:        positionsReduced.positionSummaryBase.dayChange,
-			ChangePercent:    (positionsReduced.positionSummaryBase.value / positionsReduced.positionSummaryBase.cost) * 100,
+			ChangePercent:    (change / positionsReduced.positionSummaryBase.cost) * 100,
 			DayChangePercent: (positionsReduced.positionSummaryBase.dayChange / positionsReduced.positionSummaryBase.value) * 100,
 		}
 

diff --git a/internal/position/position_test.go b/internal/position/position_test.go
@@ -102,7 +102,7 @@ var _ = Describe("Position", func() {
 				Cost:             4000,
 				Change:           1450,
 				DayChange:        625,
-				ChangePercent:    136.25,
+				ChangePercent:    36.25,
 				DayChangePercent: 11.46788990825688,
 			}
 			Expect(outputPositions["ARKW"]).To(Equal(Position{