fix: double conversion of total value

achannarasappa · Feb 15, 2021 · 2e5d30c · 2e5d30c
1 parent dd03701
commit 2e5d30c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/internal/currency/currency.go b/internal/currency/currency.go
@@ -107,7 +107,7 @@ func GetCurrencyRates(client resty.Client, symbols []string, targetCurrency stri
 func GetCurrencyRateFromContext(ctx c.Context, fromCurrency string) (float64, float64, string) {
 	if currencyRate, ok := ctx.Reference.CurrencyRates[fromCurrency]; ok {
 		if ctx.Config.Currency != "" {
-			return currencyRate.Rate, currencyRate.Rate, currencyRate.ToCurrency
+			return currencyRate.Rate, 1.0, currencyRate.ToCurrency
 		}
 
 		return 1.0, currencyRate.Rate, currencyRate.ToCurrency

diff --git a/internal/currency/currency_test.go b/internal/currency/currency_test.go
@@ -102,7 +102,7 @@ var _ = Describe("Currency", func() {
 			}
 			outputRate, outputDefaultRate, outputCurrencyCode := GetCurrencyRateFromContext(inputCtx, "USD")
 			Expect(outputRate).To(Equal(1.25))
-			Expect(outputDefaultRate).To(Equal(1.25))
+			Expect(outputDefaultRate).To(Equal(1.0))
 			Expect(outputCurrencyCode).To(Equal("EUR"))
 		})
 	})