Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for quote api response schema validation #50

Merged
merged 3 commits into from
Feb 4, 2021
Merged

Add test for quote api response schema validation #50

merged 3 commits into from
Feb 4, 2021

Conversation

priyanshus
Copy link
Contributor

@priyanshus priyanshus commented Feb 4, 2021

Please check my comment here: #15

@achannarasappa
Copy link
Owner

This looks really great! Thank you for implementing the contract test

Would you be able to fix the commitlint error (git rebase -i)? Aside from that I don't see any other reason this can't be merged but will take a closer look today.

@achannarasappa
Copy link
Owner

Scratch that request about commit message :)

@achannarasappa achannarasappa merged commit cecb313 into achannarasappa:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants