fix!: be explicit about sync/async behaviour #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crossing async boundaries is not free so allow the `Duplex` type to specify whether it is sync or async. BREAKING CHANGE: the `TSource` and `TSink` generic arguments to the `Duplex` type now refer to the stream type and not the type of objects yielded by the stream
github-actions bot
pushed a commit
that referenced
this pull request
Apr 4, 2023
## [2.0.0](v1.0.5...v2.0.0) (2023-04-04) ### ⚠ BREAKING CHANGES * the `TSource` and `TSink` generic arguments to the `Duplex` type now refer to the stream type and not the type of objects yielded by the stream ### Bug Fixes * be explicit about sync/async behaviour ([#45](#45)) ([374296f](374296f))
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
achingbrain
added a commit
to ChainSafe/js-libp2p-yamux
that referenced
this pull request
Apr 18, 2023
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not just `AsyncIterable`s. Refs: achingbrain/it-stream-types#45 BREAKING CHANGE: the type of the source/sink properties have changed
achingbrain
added a commit
to libp2p/js-libp2p-tcp
that referenced
this pull request
Apr 18, 2023
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not just `AsyncIterable`s. Refs: achingbrain/it-stream-types#45 BREAKING CHANGE: the type of the source/sink properties have changed
achingbrain
added a commit
to alanshaw/it-ws
that referenced
this pull request
Apr 18, 2023
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not just `AsyncIterable`s. Refs: achingbrain/it-stream-types#45 BREAKING CHANGE: the type of the source/sink properties have changed
achingbrain
added a commit
to libp2p/js-libp2p-webtransport
that referenced
this pull request
Apr 18, 2023
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not just `AsyncIterable`s. Refs: achingbrain/it-stream-types#45 BREAKING CHANGE: the type of the source/sink properties have changed
achingbrain
added a commit
to alanshaw/it-ws
that referenced
this pull request
Apr 18, 2023
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not just `AsyncIterable`s. Refs: achingbrain/it-stream-types#45 BREAKING CHANGE: the type of the source/sink properties have changed
achingbrain
added a commit
to libp2p/js-libp2p-websockets
that referenced
this pull request
Apr 18, 2023
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not just `AsyncIterable`s. Refs: achingbrain/it-stream-types#45 BREAKING CHANGE: the type of the source/sink properties have changed
achingbrain
added a commit
to libp2p/js-libp2p-websockets
that referenced
this pull request
Apr 18, 2023
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not just `AsyncIterable`s. Refs: achingbrain/it-stream-types#45 BREAKING CHANGE: the type of the source/sink properties have changed
achingbrain
added a commit
to libp2p/js-libp2p-daemon
that referenced
this pull request
Apr 19, 2023
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not just `AsyncIterable`s. Refs: achingbrain/it-stream-types#45 BREAKING CHANGE: the type of the source/sink properties have changed
achingbrain
added a commit
to libp2p/js-libp2p-daemon
that referenced
this pull request
Apr 19, 2023
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not just `AsyncIterable`s. Refs: achingbrain/it-stream-types#45 BREAKING CHANGE: the type of the source/sink properties have changed
wemeetagain
pushed a commit
to ChainSafe/js-libp2p-yamux
that referenced
this pull request
Apr 19, 2023
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not just `AsyncIterable`s. Refs: achingbrain/it-stream-types#45 BREAKING CHANGE: the type of the source/sink properties have changed
achingbrain
added a commit
to achingbrain/js-libp2p-noise
that referenced
this pull request
Apr 19, 2023
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not just `AsyncIterable`s. Refs: achingbrain/it-stream-types#45 BREAKING CHANGE: the type of the source/sink properties have changed
This was referenced Apr 19, 2023
achingbrain
added a commit
to achingbrain/gossipsub-js
that referenced
this pull request
Apr 19, 2023
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not just `AsyncIterable`s. Refs: achingbrain/it-stream-types#45 BREAKING CHANGE: the type of the source/sink properties have changed
wemeetagain
pushed a commit
to ChainSafe/js-libp2p-gossipsub
that referenced
this pull request
Apr 20, 2023
deps!: update stream types libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not just `AsyncIterable`s. Refs: achingbrain/it-stream-types#45 BREAKING CHANGE: the type of the source/sink properties have changed
achingbrain
added a commit
to libp2p/js-libp2p-webtransport
that referenced
this pull request
Apr 28, 2023
libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not just `AsyncIterable`s. Refs: achingbrain/it-stream-types#45 BREAKING CHANGE: the type of the source/sink properties have changed
mpetrunic
added a commit
to ChainSafe/js-libp2p-noise
that referenced
this pull request
May 5, 2023
* deps!: update stream types libp2p streams are now explicit about the types of sync/sources they provide, showing that they are `AsyncGenerator`s and not just `AsyncIterable`s. Refs: achingbrain/it-stream-types#45 BREAKING CHANGE: the type of the source/sink properties have changed * fix: interop Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com> --------- Signed-off-by: Marin Petrunic <marin.petrunic@gmail.com> Co-authored-by: Marin Petrunic <marin.petrunic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crossing async boundaries is not free so allow the
Duplextype to specify whether it is sync or async.BREAKING CHANGE: the
TSourceandTSinkgeneric arguments to theDuplextype now refer to the stream type and not the type of objects yielded by the stream