Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace err-code with CodeError #31

Closed
wants to merge 3 commits into from

Conversation

tabcat
Copy link

@tabcat tabcat commented Mar 21, 2023

Related: libp2p/js-libp2p#1269

  • deps: install @libp2p/interfaces
  • fix: replace err-code with CodeError
  • deps: remove err-code

@tabcat tabcat marked this pull request as draft March 22, 2023 05:14
@tabcat
Copy link
Author

tabcat commented Mar 22, 2023

Tests are timing out for me on with and without changes.

@p-shahi
Copy link

p-shahi commented May 30, 2023

test timeout might be occurring because it depends on your local setup with UPnP (they're not running on CI)
@achingbrain would rather have a separate dep that's not libp2p interfaces. We closed the main js-libp2p issue (propagating CodeError across the stack) so this will be treated as low priority

@tabcat tabcat closed this May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants