Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update KnownPlugins.md #58

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Update KnownPlugins.md #58

merged 1 commit into from
Aug 17, 2020

Conversation

hieplpvip
Copy link
Contributor

No description provided.

@Andrey1970AppleLife
Copy link
Contributor

But you have written that it doesn't work. acidanthera/bugtracker#1102

@hieplpvip
Copy link
Contributor Author

That issue is related to branch new-patch in which I'm trying to patch two functions in SidebarCore to allow Sidecar on iPhone.

The master branch uses a different approach (e.g. patching "iPad" -> "iXad" so it won't match any real devices) and works well. This patch only renames the identifiers; it doesn't remove the check for device type (iPad). That's why I created new-patch which completely removes all checks.

I'm really sorry for this inconvenience. Please merge this.

@Andrey1970AppleLife Andrey1970AppleLife merged commit b8eb26f into acidanthera:master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hieplpvip @Andrey1970AppleLife