Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VoodooPS2Keyboard: Local variable 'start' shadows outer function #2027

Closed
nms42 opened this issue May 28, 2022 · 0 comments · Fixed by acidanthera/VoodooPS2#52
Closed

VoodooPS2Keyboard: Local variable 'start' shadows outer function #2027

nms42 opened this issue May 28, 2022 · 0 comments · Fixed by acidanthera/VoodooPS2#52
Assignees
@PMheart
Labels
priority:normal project:ps2

Comments

@nms42
Copy link

nms42 commented May 28, 2022 

VoodooPS2Keyboard/VoodooPS2Keyboard.cpp:1519:21: style: Local variable 'start' shadows outer function [shadowFunction]
                int start = checkModifierState(kMaskLeftWindows) ? 1 : 0;
                    ^
VoodooPS2Keyboard/VoodooPS2Keyboard.h:173:10: note: Shadowed declaration
    bool start(IOService * provider) override;
         ^
VoodooPS2Keyboard/VoodooPS2Keyboard.cpp:1519:21: note: Shadow variable
                int start = checkModifierState(kMaskLeftWindows) ? 1 : 0;
                    ^
@nms42 nms42 added invalid This doesn't seem right project:ps2 priority:normal and removed invalid This doesn't seem right labels May 28, 2022
PMheart added a commit to acidanthera/VoodooPS2 that referenced this issue Aug 1, 2022
@PMheart
Fix variable shadowing 3/3
9605ede 
closes acidanthera/bugtracker#2027
@PMheart PMheart mentioned this issue Aug 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PMheart PMheart

Labels
priority:normal project:ps2
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix variable shadowing acidanthera/VoodooPS2
2 participants
@nms42 @PMheart