Update hot ACIS observations criteria #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The relatively new criteria for determining "hot ACIS" observations requires the
SPECTRAL_MAX_COUNTvalue in the obscat to be filled. If this value is not filled the obscat, the current strategy is to fall back on the "old" criteria which relied on determining the number of counts in the sequence by multiplying the expected count rate times the approved exposure.Previously, the requirement for this older criterion was that it was only valid for observations that were S3-only or S3 with a single FI chip. SOT MP is using this criterion for all ACIS observations, regardless of which chips are used, per FSDS-53. However,
acis_thermal_checkis using the criterion including the chip restrictions. This PR bringsacis_thermal_checkin line with SOT MP's software.Interface impacts
The number of ACIS observations that are allowed to go to -109 C as determined by this software will increase. They will show up in the table on the web pages.
Testing
Unit tests
Functional tests
The change to the criteria changed the answers in the unit tests. The changes to the answers were hand-checked for determine their validity.
I ran this software change on the DEC0522A load, on which the flight version of
acis_thermal_checkflagged a violation that should not have been flagged. The violation went away.