Use chandra limits

[jzuhone]

Description

This version of acis_thermal_check hands violations checking and plotting of limits over completely to the chandra_limits package. A review of the most important changes is as follows:

• As noted above, the violations checking code has been ripped out. The code that is now in chandra_limits is largely copied and refactored over from the code originally in acis_thermal_check.
• For the ACIS FP model, instead of reporting a table of "hot ACIS" observations, there is a new page linked to from the main page reporting a table of all observations and their properties in the schedule.
• The planning limit lines are now piece-wise constant, especially in the the case of the ACIS FP. Yellow limit lines remain the same.
• In the ACIS FP plots, the obsids are now only colored red and green depending on whether they are ACIS-I or ACIS-S.
• The validation limits code has been simplified as there was a lot of duplication. This largely occurred in commit d591e91.

Practical effects of these changes:

• Plots look somewhat different because of the change in planning limits, especially the ACIS FP plot.
• ACIS FP data quality violations are no longer reported during the taking of a bias.
• ACIS FP -105 C observations are now supported. One of the plots has had its upper limit set to -103 C to accommodate this.

Interface impacts

The table reporting violations on the webpages has changed slightly, but is human-read. Plots show limit lines as a function of time instead of every limit line across the whole plot; also human-read.

Testing

Unit tests

• No unit tests
• Mac
• Linux
• Windows

All tests which do not depend on violations checking pass without any answer updates as expected. Some answer changes are necessary for the FP and a couple of other models. All of these answer changes were hand-checked and they were found to be correct based on the code changes.

Independent check of unit tests by [REVIEWER NAME]

• [PLATFORM]:

Functional tests

Ran the code in this PR at weekly load reviews for several weeks and results were checked for consistency with flight code; any differences are explained by changes to the violations checking changes.

[jazan12]

Just want to confirm the intentionality of having syntax of odb.caution for the limits for the official models vs the safety.caution for the "informal" models.

[jzuhone]

It's not so much "official" vs "informal" as what limits are stored in the ODB (related to engineering telemetry) vs the ones related to DEA HKP telemetry

[jazan12]

I don't see where TASK_DATA is defined.

[jeanconn]

In passing - I think it is imported from utils here

acis_thermal_check/acis_thermal_check/main.py

Line 25 in 4f7c496

TASK_DATA,

[jazan12]

Thanks

…

On Thu, Mar 28, 2024 at 8:47 AM Jean Connelly ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In acis_thermal_check/main.py <#71 (comment)> : > @@ -1393,6 +1286,23 @@ def write_index_rst(self, outdir, context): # Render the template and write it to a file with open(outfile, "w") as fout: fout.write(template.render(**context)) + if self.msid == "fptemp": + # For the ACIS FP limit we write out an obsid table + context["acis_obs"] = self.acis_and_ecs_obs + template_path = ( + TASK_DATA / "acis_thermal_check/templates/obsid_template.rst" In passing - I think it is imported from utils here https://github.com/acisops/acis_thermal_check/blob/4f7c496bb51f327b16a75066896d5c5e5dfbe55d/acis_thermal_check/main.py#L25 — Reply to this email directly, view it on GitHub <#71 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACN5TGO43PQIXA35QFQCBG3Y2QGMDAVCNFSM6AAAAABEQX7YRSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNRWGEYDMMBTGY> . You are receiving this because you commented.Message ID: ***@***.***>

[jazan12]

Good, so long as the syntax was as intended

…

On Thu, Mar 28, 2024 at 9:08 AM John ZuHone ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ On acis_thermal_check/tests/bep_pcb/answers/JUL2919A_viol.json <#71 (comment)> : It's not so much "official" vs "informal" as what limits are stored in the ODB (related to engineering telemetry) vs the ones related to DEA HKP telemetry — Reply to this email directly, view it on GitHub <#71 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACN5TGNJQS6CFRF5TDSDKLDY2QI5NAVCNFSM6AAAAABEQX7YRSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNRWGE3TCNZTGA> . You are receiving this because you commented.Message ID: ***@***.***>

[jazan12]

All my comments were addressed. Looks good!

[Gregg140]

Looks good to me.