-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update acisfp_check for acis_thermal_check 3.0 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…events that from happening
… being met anyway.
jzuhone
requested review from
cegrant,
Gregg140,
javierggt,
jazan12,
jeanconn,
pplucinsky and
taldcroft
April 7, 2020 00:05
jazan12
reviewed
Apr 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not so sure about parsing the .rst syntax, but looked through all the coding and no objections here.
…t working anyway, and we also don't care)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements an update to achieve compatibility with
acis_thermal_check
version 3.0 (PR acisops/acis_thermal_check#25). In essence, it does the following:ACISThermalCheck
toACISFPCheck
and stores all of the information specific to the ACIS FP model inside this class, such as validation limits, histogram limits, etc.calc_model
becomes the_calc_model_supp
method which overrides a stub in theACISThermalCheck
class. This is designed to put the common model functionality in the super class and allow for model-specific customizations to be carried out in this method.run
method instead of the class__init__
.acis_thermal_check
testing machinery and stores answers inside the packageTesting