-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplification of code, use cxotime, fixing bugs with violations reporting #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e stopped trying a long time ago
…he FEP-power-off sequence as an obsid interval
…The differences are understood.
…ge to the answers, but only one!
Gregg140
approved these changes
Jan 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
This was referenced Jan 5, 2021
Merged
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes a number of changes which simplifies code, reduces duplication, and fixes a bug:
acis_thermal_check
refactor in Refactoring of limit handling, allowing for more customizations, use cxotime acis_thermal_check#37 allows for further code removal and simplification inACISFPCheck
.paint_perigee
function, which plotted perigee passages on prediction plots, and additional required code for this purpose, has been moved toacis_thermal_check
, since all models will now use it.acis_thermal_check
were minor and the functionality has been merged into that one.cxotime
is now used instead ofChandra.Time
.Minor updates to the regression tests are also required, to account for:
12:00:00
to the epoch value in the test model specification to accommodate the switch tocxotime
The code changes here require acisops/acis_thermal_check#37.
Testing