Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to thermal model support #14

Merged
merged 18 commits into from
Aug 2, 2024
Merged

Updates to thermal model support #14

merged 18 commits into from
Aug 2, 2024

Conversation

jzuhone
Copy link
Member

@jzuhone jzuhone commented Jul 27, 2024

Description

This PR achieves a number of things related to thermal model support.

  • Adds support for the 1DPAMYT model.
  • Adds the ability to ignore eclipses in ThermalModelRunner.
  • In ThermalModelRunner, if states is None, we obtain the commanded states using kadi. This is a change from the previous behavior which used the states attribute from the xija model. However, the latter is not the true commanded states but an interpolation to the model times.
  • Supports making the solarheat pitch bin plots for models like 1PDEAAT, CEA, and the upcoming FP model which uses pitch bins at different SIM-Z.
  • Improve logic in ThermalModelRunner for determining when pitch and off-nominal roll have been supplied vs. when they need to be obtained from kadi.
  • Fixed issues with docs

Interface impacts

None

Testing

Answers for one test had to be bumped--verified that the changes were due to the changes in this PR

Unit tests

  • No unit tests
  • Mac
  • Linux
  • Windows

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

Doc examples were checked and provide the correct results.

@jzuhone jzuhone requested review from Gregg140 and jazan12 July 27, 2024 02:09
Copy link

@jazan12 jazan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

Copy link

@Gregg140 Gregg140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jzuhone jzuhone merged commit e4d75b1 into master Aug 2, 2024
@javierggt javierggt mentioned this pull request Nov 7, 2024
@javierggt javierggt mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants