Modifications to Baskstop History to accommodate data structure change… #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s forced by Shiny
taldcroft
approved these changes
Dec 1, 2020
|
Backstop History update merged after approval. |
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s forced by Shiny
Description
The Shiny release is deprecating Ska.ParseCM and moving towards using kadi for
reading the backstop commands from the load CR*.backstop files. This
change includes #14 and alterations to data structures returned by the call to the kadi.commands.get_cmds_from_backstop method, as compared to the data structures returned by ParseCM.
As Backstop History inserts commends for all Non-Load events, the change
in the data structures necessitated modification of the structure of the
commands which Backstop History inserts into the history. Dictionary keyword changes necessitated changes in the code when those dictionary elements are referenced.
Testing
Fixes #