Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run on filesystems which are not case-sensitive #19

Merged
merged 1 commit into from
Apr 23, 2021

Conversation

jzuhone
Copy link
Member

@jzuhone jzuhone commented Apr 21, 2021

Description

This PR allows for backstop_history to be used on case-insensitive filesystems (e.g. Windows) by refining the glob for backstop files to avoid finding the cr_test.backstop file.

Testing

  • Passes unit tests on macOS and Windows
  • Functional testing

Copy link
Contributor

@Gregg140 Gregg140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jzuhone
Copy link
Member Author

jzuhone commented Apr 23, 2021

@Gregg140 ok if I merge? This is so trivial I think I only need your approval.

@jzuhone
Copy link
Member Author

jzuhone commented Apr 23, 2021

@Gregg140 or you can merge

@Gregg140
Copy link
Contributor

Go ahead and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants