Incorporation of new RTS files for new Long Term ECS SI modes #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzuhone
reviewed
May 22, 2023
backstop_history/CR_Commands.dat
Outdated
| @@ -34,10 +34,21 @@ | |||
| "WSPOW00F1E": "1999:001:00:00:00.000 | 20 0 | ACISPKT | TLMSID= WSPOW00F1E, CMDS= 5, WORDS= 7, PACKET(40)= D0000000000000000000000000000000000 , SCS= 107, STEP= 1", | |||
| "WSPOW1E01E": "1999:001:00:00:00.000 | 20 0 | ACISPKT | TLMSID= WSPOW1E01E, CMDS= 5, WORDS= 7, PACKET(40)= D0000000000000000000000000000000000 , SCS= 107, STEP= 1", | |||
|
|
|||
| "OORMPDS": "1999:001:00:00:00.000 | 20 0 | COMMAND_SW | TLMSID= OORMPDS, HEX= 800030C, MSID= OORMPDS, SCS= 107, STEP= 1", | |||
| "OORMPDS": "1999:001:00:00:00.000 | 20 0 | COMMAND_SW | TLMSID= OORMPDS, HEX= 800030C, MSID= OORMPDS, SCS= 107, STEP= 1", | |||
There was a problem hiding this comment.
Don't know if the space alignment matters here or not
There was a problem hiding this comment.
Didnt matter but it's fixed.
jzuhone
reviewed
May 22, 2023
| ('substitution_parameter_value', '|U20'), | ||
| ('DELTA','<f8'), | ||
| ('SCS_NUM', '|U5')] | ||
| ('time','<f8'), |
There was a problem hiding this comment.
no big deal, but something went wrong with the whitespace here
There was a problem hiding this comment.
Nothing wrong with the whitespace. 7 of the items in the DTYPE specification were moved over to align under "date"
jzuhone
approved these changes
May 22, 2023
|
@Gregg140 - I have some questions about testing before I release the FSDS ticket for review. Can you elaborate on the unit testing?
|
|
It is documented in an update to the Release Notes and the answers to
your questions
are contained in the update
…On 5/23/23 14:54, Tom Aldcroft wrote:
@Gregg140 <https://github.com/Gregg140> - I have some questions about
testing before I release the FSDS ticket for review.
Can you elaborate on the unit testing?
* How did you perform the isolated tests of processRTS for each RTS
and compare to the expected output?
* How did you generate a new assembled history for each of the new
RTS's.
* How did you determine that the new assembled history matched the
expected commands from the RTS.
* Where is this documented (in a perfect world).
—
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANFYCT27ENVUCDSUJOZ6C3XHUBYBANCNFSM6AAAAAAYIG6KBU>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@Gregg140 - thanks for the update, looks good now. |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New variations of SI modes, and their associated RTS files, for Long Term ECS
measurements were created to provide a more flexible chip selection.
Backstop History was updated to incorporate these new RTS files in future
history assemblies.
The added RTS files are:
1_ECS2.RTS
1_ECS3A.RTS
1_ECS3B.RTS
1_ECS5.RTS
1_ECS6.RTS
Changes to the python files consist mainly of documentation changes. The major
portion of the update is to include the new RTS files in the directory and an update to a
data file.
Interface impacts
None
Testing
Unit tests
Unit and regression testing completed, using all new and operational RTS files,
to assure that the assembled histories correctly contained the commands
from the new RTS files whenever they were used.
Unit tests included:
Isolated tests of processRTS which reads and process an RTS file to assure the new files
were correctly read and processed by the code.
An assembly of the history of the SEP0917 load after an interrupt of the SEP0417
load to assure the assembled history contained the correct RTS commands
Functional tests
Regression testing Loads were full LR runs with checks of the thermal model outputs
and assembled history files to assure correct processing of the new RTS files. Thermal
model outputs were compared to the production load output to check the resultant
change in the thermal response where appropriate.
Loads used for Regression testing:
FEB2023B Maneuver-Only load executed after the Full Stop interruption of
the FEB1323 load.
FEB2423A Return to Science load which is a TOO interruption of FEB2023.
All tests passed.
Objectives and changes reviewed by ACIS Ops.