-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fall 2019 recalibration #17
Conversation
I think for this release the plan will be to have the json files match between this ACIS dpa model and the Matlab 2019_207 release. @matthewdahmer do you agree the file in this branch is what you expect? |
Yes, I have confirmed the correct file is used in the FOT Tools, indicated by a commit hash of 41a9ff3.
… On Dec 16, 2019, at 2:39 PM, Jean Connelly ***@***.***> wrote:
I think for this release the plan will be to have the json files match between this ACIS dpa model and the Matlab 2019_207 release. @matthewdahmer do you agree the file in this branch is what you expect?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
dpa_check/Release_Notes_V2.5.0.txt
Outdated
=============== | ||
|
||
Deploy after the first segment of the load presently being reviewed, | ||
starts execution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how this bit applies. Generally I just promote an updated dpa_check after loads are approved. This text suggests waiting until the next week to promote.
Deployment Plan | ||
=============== | ||
|
||
Deploy after a new FOT Tools release has FDB approval. Will be running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. If the plan is to deploy after 2019_207 is promoted, this looks good.
I think this is good to merge and tag. |
I’ll handle this. |
With regard to merge and tag, I think we can move to a plan where you merge and tag after github approval without waiting for LR approval. My point is just that the sooner you merge and tag the sooner it is convenient for us to actually build a dpa_check package and have it ready. |
@jeanconn sure thing—I’m on the road at the moment but I plan to tag here in a little bit |
Fall 2019 re-calibration.