Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall 2019 recalibration #17

Merged
merged 4 commits into from
Dec 18, 2019
Merged

Fall 2019 recalibration #17

merged 4 commits into from
Dec 18, 2019

Conversation

Gregg140
Copy link
Contributor

Fall 2019 re-calibration.

@jeanconn
Copy link
Contributor

I think for this release the plan will be to have the json files match between this ACIS dpa model and the Matlab 2019_207 release. @matthewdahmer do you agree the file in this branch is what you expect?

@matthewdahmer
Copy link

matthewdahmer commented Dec 16, 2019 via email

Copy link
Member

@jzuhone jzuhone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go.

Copy link

@jazan12 jazan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

===============

Deploy after the first segment of the load presently being reviewed,
starts execution.
Copy link
Contributor

@jeanconn jeanconn Dec 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how this bit applies. Generally I just promote an updated dpa_check after loads are approved. This text suggests waiting until the next week to promote.

Deployment Plan
===============

Deploy after a new FOT Tools release has FDB approval. Will be running
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. If the plan is to deploy after 2019_207 is promoted, this looks good.

@jeanconn
Copy link
Contributor

I think this is good to merge and tag.

@jzuhone
Copy link
Member

jzuhone commented Dec 18, 2019

I’ll handle this.

@jeanconn
Copy link
Contributor

With regard to merge and tag, I think we can move to a plan where you merge and tag after github approval without waiting for LR approval.

My point is just that the sooner you merge and tag the sooner it is convenient for us to actually build a dpa_check package and have it ready.

@jzuhone
Copy link
Member

jzuhone commented Dec 18, 2019

@jeanconn sure thing—I’m on the road at the moment but I plan to tag here in a little bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants