Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customizations to support checking +12 degC/0 FEPs violations, other minor updates #28

Merged
merged 6 commits into from
Jan 5, 2021

Conversation

jzuhone
Copy link
Member

@jzuhone jzuhone commented Jan 4, 2021

Description

This PR implements changes to support tracking, plotting, and reporting of violations of the +12 degC limit when 0 FEPs are on.

Minor updates to the regression tests are also required, to account for:

  • The additions of violation durations to the violation test answers
  • The changing of the limit variable names
  • Adding explicit 12:00:00 to the epoch value in the test model specification to accommodate the switch to cxotime

The code changes here require acisops/acis_thermal_check#37.

Testing

  • Passes unit tests on MacOS, linux, Windows (at least one required)
  • Functional testing

Copy link
Contributor

@Gregg140 Gregg140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jzuhone jzuhone merged commit 82c1d64 into acisops:master Jan 5, 2021
@javierggt javierggt mentioned this pull request Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants