Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update regression testing #6

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Update regression testing #6

merged 2 commits into from
Jan 5, 2021

Conversation

jzuhone
Copy link
Member

@jzuhone jzuhone commented Jan 4, 2021

Description

Minor updates to the regression tests are required, to account for changes in acisops/acis_thermal_check#37:

  • The additions of violation durations to the violation test answers
  • The changing of the limit variable names
  • Adding explicit 12:00:00 to the epoch value in the test model specification to accommodate the switch to cxotime

Testing

  • Passes unit tests on MacOS, linux, Windows (at least one required)
  • Functional testing

Gregg140
Gregg140 approved these changes Jan 5, 2021
View reviewed changes
Copy link

@Gregg140 Gregg140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@jzuhone jzuhone merged commit 5a7e8dc into acisops:master Jan 5, 2021
This was referenced Jan 5, 2021
Closed
Merged
@javierggt javierggt mentioned this pull request Mar 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gregg140 Gregg140 Gregg140 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jzuhone @Gregg140