update psmc_check for acis_thermal_check 3.0 #20
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements an update to achieve compatibility with
acis_thermal_check
version 3.0 (PR acisops/acis_thermal_check#25). In essence, it does the following:ACISThermalCheck
toPSMCCheck
and stores all of the information specific to the 1PDEAAT model inside this class, such as validation limits, histogram limits, etc.calc_model
becomes the_calc_model_supp
method which overrides a stub in theACISThermalCheck
class. This is designed to put the common model functionality in the super class and allow for model-specific customizations to be carried out in this method.run
method instead of the class__init__
.acis_thermal_check
testing machinery and stores answers inside the packageTesting