Merge v1.2 and do structure/code refactoring to be more simple. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put API changes to be valid with the newest GameJolt API. Refactor code to be more flexible and clean. Allow to use HTTP+SSL (HTTPS) GameJolt API.
Reorgenize structure to be more simplified and most recent. Update description of plugin.
Fix bug, that when sending parameters, which are null, plugin injects them as 'Null' value, which produce wrong work. Also modify a code to be more clear with generate final url (simplify).
In the code:
Create one common signal for everything.
Store whole information about results inside plugin.
'Hide' internal functions.
Append some verbose reporting.
Use default function parameters as null.
Remove unwanted tables and simplify calling url composer.
Parse JSON response and return it.
Divide score API to smaller pieces - global/guest/user.
For data API - global flag to use global data
or authenticated user specific data.
In documentation:
Update readme file to correspond actual version.
Append missing description of new function/argues.
Append hints.
Update README
Create Sample project
Git ignore godot import files
Move plugin API to dedicated folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.