Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vultr DNS: fix "grep: repetition-operator operand invalid" on FreeBSD #4266

Merged
merged 4 commits into from
Feb 3, 2023

Conversation

skyksandr
Copy link
Contributor

@skyksandr skyksandr commented Aug 24, 2022

Part 1

@mjkrg reports here #2374 integration is no longer working on FreeBSD.
This PR aims to fix it.

On line 119, containing the command grep '^\{.*\}', on FreeBSD it needs an -E option to be able to parse the extended regular expression otherwise it chokes with the error message: "grep: repetition-operator operand invalid".

Part 2

The | tr -d '"' added to fix following error on cleanup stage:

Please refer to https://curl.haxx.se/libcurl/c/libcurl-errors.html for error code: 22
Error domains/skyder.by/records/"6d139034-bbfb-407d-bdf8-1619cfca45c8"
{"error":"resource ID cannot contain special characters","status":400}

@github-actions
Copy link

Welcome
Please make sure you're read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨

@skyksandr skyksandr force-pushed the master branch 2 times, most recently from 405d6df to 58e58d3 Compare August 24, 2022 02:10
@Neilpang
Copy link
Member

@skyksandr skyksandr marked this pull request as ready for review February 3, 2023 07:09
@skyksandr
Copy link
Contributor Author

@Neilpang Here is CI run after rebasing on current master:
https://github.com/skyksandr/acme.sh/actions/runs/4081483447

@Neilpang Neilpang merged commit f7f1168 into acmesh-official:dev Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants