-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eslint 8 update #38
Eslint 8 update #38
Conversation
Just noticed on other repos that the latest version of |
This has now been updated |
@tomislav-s Know any good way to test this? 😬 |
The simplest way is to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting a couple of errors when running all tests:
lerna ERR! npm run test exited 1 in '@acolorbright/eslint-config-ts-react'
lerna ERR! npm run test stdout:
> @acolorbright/eslint-config-ts-react@2.2.0 test
> eslint .
/Users/alice/Projects/ACB/acb-tools-and-configs/packages/eslint-config-ts-react/rules/react.js
3:23 error Replace `⏎··require('@acolorbright/eslint-config-ts/rules/style')` with `·require('@acolorbright/eslint-config-ts/rules/style')⏎··` prettier/prettier
✖ 1 problem (1 error, 0 warnings)
1 error and 0 warnings potentially fixable with the `--fix` option.
lerna ERR! npm run test stderr:
Warning: React version was set to "detect" in eslint-plugin-react settings, but the "react" package is not installed. Assuming latest React version for linting.
lerna ERR! npm run test exited 1 in '@acolorbright/eslint-config-ts-react'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞🏻
eslint
and all related packagesnpx run lerna test