-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unsupported ESTree node types with the walker #555
Comments
The code was written against an old version of the format. It's probably straightforward to add these -- want to submit a pull request? |
Done in #558 |
What's the status of this? I apparently ran into this issue where my SwitchCase wasn't being called in |
@marijnh I want to help with this issue. Could I make a PR? |
All the node types emitted by the parser should be handled by the walker. If you have a specific example of one that isn't, do let us know. |
Example from first message in issue still doesn't work in the latest version. |
Oh right, I think I see what you mean. Does attached patch help? |
Yeah, it helps ) |
Great. I've tagged it as acorn-walk 8.3.4 |
The walker at
src/walk/index.js
does not catch all the node types defined by the ESTree spec.Example:
I found this problem for the following ESTree types:
SwitchCase
,ClassBody
,TemplateElement
,ExportSpecifier
.The following abstract types are also missing:
Declaration
,ModuleDeclaration
.The text was updated successfully, but these errors were encountered: