Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce a mergeStatus column when joining frames #158

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

teto
Copy link
Contributor

@teto teto commented Jun 23, 2021

to mimic pandas mergeStatus column: specifies how the merge was done, leftempty, rightempty, present in both frames etc

WIP: I would like some feedback on the API n case it would be ok to upstream.

Right now I struggle with issues like Grouping (Record fs) ■ • Expected kind ‘[(GHC.Types.Symbol, *)]’, but ‘fs’ has kind ‘[*]’

Matthieu Coudron added 3 commits June 23, 2021 22:56
@acowley
Copy link
Owner

acowley commented Jun 24, 2021

Very ambitious! I still do not really understand how the Grouping stuff works, so I don't have any instant solutions.

Is the TODO suggesting that you want the user to supply the name of the status column, or that we need to do it?

My reading is that a type variable like rs is a list of kind [(GHC.Types.Symbol, *)], so we should append '("merge_status", MergeStatusField) to the list of post-join fields.

@acowley acowley deleted the branch acowley:master October 22, 2023 18:29
@acowley acowley closed this Oct 22, 2023
@acowley acowley reopened this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants