Skip to content
This repository has been archived by the owner on Oct 18, 2023. It is now read-only.

Make field_configured_skus non translatable as it is global level attribute in MDC. #129

Merged
merged 2 commits into from
Mar 14, 2019
Merged

Make field_configured_skus non translatable as it is global level attribute in MDC. #129

merged 2 commits into from
Mar 14, 2019

Conversation

nikunjkotecha
Copy link

No description provided.

@nikunjkotecha nikunjkotecha force-pushed the make_variants_info_non_translatable branch from 5238a3a to 45ca0e9 Compare March 8, 2019 11:28
@miromichalicka miromichalicka self-requested a review March 14, 2019 12:22
miromichalicka
miromichalicka suggested changes Mar 14, 2019
View reviewed changes
Copy link
Contributor

@miromichalicka miromichalicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach limits the possibilities of the module. I suggest that we leave field storage translatable and field configs as not. That way if you need to support use case where you need to translate your fields, you are able to do that simple way.

@nikunjkotecha
Copy link
Author

Updated, making only fields non-translatable now.

@miromichalicka miromichalicka merged commit 660e96c into acquia:8.x-1.x Mar 14, 2019
@nikunjkotecha nikunjkotecha deleted the make_variants_info_non_translatable branch March 14, 2019 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@miromichalicka miromichalicka miromichalicka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikunjkotecha @miromichalicka @nikunjhk