Allow setting attribute weights per attribute set. #47
Conversation
nikunjkotecha
force-pushed
the
attribute_weights_per_attribute_set
branch
from
627bcf6 to
c7ac5b4
Compare
This comment has been minimized.
This comment has been minimized.
|
Hi Nikunj, there are some nice ode changes here but we expect attribute weights to by synchronized from the ecommerce system and not set in Drupal. Do you agree? Is this a quick-fix until we can implement synchronisation of attribute weights (sort order)? |
|
Hi @malachy-mcconnell, I checked the code around automated synchronisation of attribute weights. But that still doesn't support multiple attribute (like the old code). I updated the code around extractConfigurableOptions too in the PR and updated logic should work as is. Probably we may want to set default value in config to Sortable weights is something we will need to define - reason behind that - we may not have all the attributes in taxonomy terms and it is a performance killer which we should avoid till really required in the project. |
nikunjkotecha
force-pushed
the
attribute_weights_per_attribute_set
branch
from
c7ac5b4 to
844ee31
Compare
|
On hold. Do not merge until the requested Dependency Injection can be added. |
…s_per_attribute_set Conflicts: modules/acm_sku/src/Plugin/AcquiaCommerce/SKUType/Configurable.php
|
fixed conflicts |
…s_per_attribute_set
…s_per_attribute_set Conflicts: modules/acm_sku/acm_sku.services.yml
No description provided.