This repository has been archived by the owner on Oct 18, 2023. It is now read-only.
Use Drupal httpClient to ensure server is not slowed down for invalid urls. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Check to ensure errors like 404, 403, etc. are catched and empty file | ||
| // not saved in SKU. | ||
| $client = \Drupal::httpClient(); |
There was a problem hiding this comment.
can you inject this through constructor please?
There was a problem hiding this comment.
bibliophileaxe
force-pushed
the
file-download
branch
2 times, most recently
from
4bc6e5b to
59fa614
Compare
| // not saved in SKU. | ||
| $client = \Drupal::httpClient(); | ||
| try { | ||
| $file_data = $client->get($data['file']); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using file_get_contents for downloading files. We can use \Drupal::httpClient() instead to download file and make it fast. This also sets a server timeout of 30seconds for invalid urls.