This repository has been archived by the owner on Oct 18, 2023. It is now read-only.
Drupal module namespacing #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miromichalicka
requested review from
grasmash,
TravisCarden and
malachy-mcconnell
added 2 commits
October 16, 2018 12:55
TravisCarden
approved these changes
Oct 16, 2018
There was a problem hiding this comment.
This looks good to me, @miromichalicka! I didn't fully appreciate before the fact that the "base module" would be both empty and hidden. I don't immediately think of any obvious problems with that, but it is rather non-standard, so you'll want to test carefully. You might also reach out to someone in PS for a second review. @arknoll might be able to recommend someone for you. @arknoll, see https://backlog.acquia.com/browse/PF-1542 for context.
malachy-mcconnell
approved these changes
Oct 16, 2018
miromichalicka
changed the title
|
I did some manual testing and it seems fine. Now we need to merge this, so we can create new release on d.o and test composer. |
csibar
approved these changes
Oct 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.