Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #45: Site:install command fails with Drush 11. #48

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Conversation

chandan-singh7929
Copy link
Contributor

Motivation

Fixes:
Fatal error: Uncaught ArgumentCountError: Too few arguments to function Acquia\Drupal\RecommendedSettings\Drush\Commands\MultisiteDrushCommands::__construct(), 0 passed and exactly 1 expected in /app/vendor/acquia/drupal-recommended-settings/src/Drush/Commands/MultisiteDrushCommands.php on line 34

Proposed changes
Use static method call instead of DI

Alternatives considered

Testing steps

@vishalkhode1 vishalkhode1 force-pushed the drush11 branch 8 times, most recently from 69f1ee8 to e5b52b7 Compare March 26, 2024 08:49
@vishalkhode1 vishalkhode1 changed the title ACMS-000: Use Drush::bootstrapManager() instead service. Issue #45: Unable to run Drush command after using this package to replace BLT. Mar 26, 2024
@vishalkhode1 vishalkhode1 changed the title Issue #45: Unable to run Drush command after using this package to replace BLT. Issue #45: Site:install command fails with Drush 11. Mar 26, 2024
@vishalkhode1 vishalkhode1 merged commit b14e273 into develop Mar 26, 2024
5 checks passed
@vishalkhode1 vishalkhode1 deleted the drush11 branch March 26, 2024 08:57
@vishalkhode1 vishalkhode1 linked an issue Mar 26, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to run Drush command after using this package to replace BLT
2 participants