Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve(networks): Support tagging chain families #57

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

pxrl
Copy link
Contributor

@pxrl pxrl commented Jul 12, 2024

Currently only identifying OP stack chains, but future candidates would be the corresponding variants from Arbitrum, Polygon, zkSync, ...

Currently only identifying OP stack chains, but future candidates would
be the corresponding variants from Arbitrum, Polygon, zkSync, ...
@pxrl pxrl requested review from dohaki and bmzig July 12, 2024 14:48
Copy link
Contributor

@bmzig bmzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We can probably shorten/remove some functions in the SDK with this.

@pxrl
Copy link
Contributor Author

pxrl commented Jul 12, 2024

Looks good. We can probably shorten/remove some functions in the SDK with this.

Yeah - that's in the pipeline 👍 across-protocol/sdk#683

@pxrl pxrl merged commit 112e2cc into master Jul 12, 2024
@pxrl pxrl deleted the pxrl/family branch July 12, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants