improve(relayer): Support dynamic handover in production #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fast relayer can presently have multiple concurrent instances for a short period of time because there is no method of coordinating the "active" relayer. This can cause some collisions when both relayer instances attempt to fill the same transaction(s), and requires that the relayer be stopped via a SIGHUP, which is slightly awkward in the serverless environment. This change instead uses redis as a coordination mechanism between relayer instances, such that a new relayer will update a specific redis record when it is ready to take over from any previous instance. Likewise, and existing instance will detect when the record is updated and will gracefully exit thereafter.
pxrl
requested review from
mrice32,
nicholaspai and
james-a-morris
as code owners
pxrl
commented
Aug 24, 2024
The relayer in looping mode is currently the only bot that's really suited for this, because it has a natural recurring point to check for handover. The other bots don't yet have this so it's not really clear for me how they'd benefit from it...but in a world where they are more event-based (i.e. precomputing executions and waiting for the right block to execute them) then I think this could be pretty beneficial and would definitely be worth generalising. |
pxrl
commented
Sep 11, 2024
pxrl
commented
Sep 11, 2024
nicholaspai
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fast relayer can presently have multiple concurrent instances for a short period of time because there is no method of coordinating the "active" relayer. This can cause some collisions when both relayer instances attempt to fill the same transaction(s), and requires that the relayer be stopped via a SIGHUP, which is slightly awkward in the serverless environment.
This change instead uses redis as a coordination mechanism between relayer instances, such that a new relayer will update a specific redis record when it is ready to take over from any previous instance. Likewise, and existing instance will detect when the record is updated and will gracefully exit thereafter.