improve: swap all Ovm adapters (excl. Optimism/Base) w/ generic adapter #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bennett <bennett@umaproject.org>
bmzig
requested review from
mrice32,
nicholaspai,
pxrl and
james-a-morris
as code owners
bmzig
commented
Sep 16, 2024
Signed-off-by: bennett <bennett@umaproject.org>
Signed-off-by: bennett <bennett@umaproject.org>
bmzig
commented
Sep 17, 2024
| @@ -62,7 +62,7 @@ export class BlastBridge extends BaseBridgeAdapter { | |||
| const l2Bridge = this.getL2Bridge(); | |||
| const events = await paginatedEventQuery( | |||
| l2Bridge, | |||
| l2Bridge.filters.ERC20BridgeFinalized(l1Token, undefined, fromAddress), | |||
| l2Bridge.filters.ERC20BridgeFinalized(undefined, l1Token, fromAddress), | |||
There was a problem hiding this comment.
This was actually an issue where I assumed the blast bridge followed the same interface as the OpStackDefaultERC20Bridge finalization events, but actually the token address positions are swapped. I.e. the first position is the address of USDB and the second position is DAI on mainnet, not the other way around.
Signed-off-by: bennett <bennett@umaproject.org>
|
This is ready to go in. |
pxrl
approved these changes
Sep 20, 2024
| logger, | ||
| SUPPORTED_TOKENS[MODE], | ||
| spokePoolClients, | ||
| filterMonitoredAddresses(MODE) | ||
| bridges, |
There was a problem hiding this comment.
Is bridges used anywhere else? Could maybe squash it?
Suggested change
| bridges, | |
| constructBridges(MODE), |
|
@bmzig Should we get this one in today? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of migrating the op-stack adapters. This moves Mode, Redstone, Zora, Blast, and Lisk to the generic adapter format, leaving only Optimism and Base as the only adapters still with the "legacy" structure.