Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(finalizer): Upgrade eth-optimism/sdk version to take advantage of updated cross-chain messenger #847

Merged
merged 3 commits into from
Jul 31, 2023

Conversation

nicholaspai
Copy link
Member

@nicholaspai nicholaspai commented Jul 31, 2023

This PR removes the dependency on a cloned version of the @eth-optimism/sdk-2.1.3 repo that added a bug fix to handle multiple withdrawal messages in the same L2 transaction post-bedrock.

The eth-optimism/sdk as of version 3.1 now includes this logic

Resolves ACX-1203

…f updated cross-chain messenger

This PR removes the dependency on a cloned version of the `@eth-optimism/sdk-2.1.3` repo that added a bug fix to handle multiple withdrawal messages in the same L2 transaction post-bedrock.

The `eth-optimism/sdk` as of version 3.1 now includes this logic
@linear
Copy link

linear bot commented Jul 31, 2023

Copy link
Contributor

@mrice32 mrice32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Assume the additional undefined in the calls is just because the interfaces changed a bit. Otherwise, seems uncontroversial!

@nicholaspai
Copy link
Member Author

LGTM! Assume the additional undefined in the calls is just because the interfaces changed a bit. Otherwise, seems uncontroversial!

Exactly

@nicholaspai nicholaspai merged commit f744dd5 into master Jul 31, 2023
2 checks passed
@pxrl pxrl deleted the optimism-sdk-3.1 branch September 5, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants