improve(ProviderUtils): Add filtered key to eth_getLogs #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've seen QuickNode add in a `transactionLogIndex` field which isn't in the spec and is causing quorum agreement issues
nicholaspai
requested review from
mrice32,
pxrl and
james-a-morris
as code owners
james-a-morris
approved these changes
Aug 3, 2023
src/utils/ProviderUtils.ts
Outdated
Comment on lines
103
to
110
| const compareResultsAndFilterIgnoredKeys = (ignoredKeys: string[], rpcResultA: any, rpcResultB: any): boolean => { | ||
| const ignoredMappingsA = deleteIgnoredKeys(ignoredKeys, rpcResultA); | ||
| const ignoredMappingsB = deleteIgnoredKeys(ignoredKeys, rpcResultB); | ||
| const result = lodash.isEqual(rpcResultA, rpcResultB); | ||
| addIgnoredFilteredKeys(ignoredMappingsA, rpcResultA); | ||
| addIgnoredFilteredKeys(ignoredMappingsB, rpcResultB); | ||
| return result; | ||
| }; |
There was a problem hiding this comment.
It may be beneficial to break this out into its own non-anonymous function definition as its static.
There was a problem hiding this comment.
perhaps this should just be a common utility. Thoughts on this refactor? 93eaae5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen QuickNode add in a
transactionLogIndexfield which isn't in the spec and is causing quorum agreement issues