feat(Dataworker): ZkSync should count ETH and WETH towards balance needed to execute leaves #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eded to execute leaves Current code assumes only OVM chains need to count both ETH and WETH towards balance that can be used to execute spoke leaves
nicholaspai
requested review from
mrice32,
pxrl and
james-a-morris
as code owners
src/dataworker/DataworkerUtils.ts
Outdated
| // then it should return both ETH and WETH. For other chains, it should only return the l2TokenAddress. | ||
| function getWethAndEth(chainId): string[] { | ||
| const wethAndEth = [CONTRACT_ADDRESSES[chainId].weth.address, CONTRACT_ADDRESSES[chainId].eth.address]; | ||
| if (wethAndEth.some((chainId) => !isDefined(chainId))) { |
There was a problem hiding this comment.
Is chainId supposed to be a chain id or a token address?
There was a problem hiding this comment.
ah yes it should be a token address, will rename
Co-authored-by: James Morris, MS <96435344+james-a-morris@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.