Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ZkSync function to AtomicWethDepositor #875

Merged
merged 7 commits into from
Aug 11, 2023

Conversation

nicholaspai
Copy link
Member

@nicholaspai nicholaspai commented Aug 11, 2023

Resolves ACX-1421

@nicholaspai nicholaspai marked this pull request as ready for review August 11, 2023 14:57
@linear
Copy link

linear bot commented Aug 11, 2023

ACX-1421 use AtomicWethDepositor to bridge ETH

Currently the inventory manager adapter atomically (1) unwraps WETH and (2) bridges ETH but we can save gas by using a custom contract similar to how we do so for Polygon, and OVM chains

https://github.com/across-protocol/relayer-v2/pull/874/files

Copy link
Contributor

@mrice32 mrice32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicholaspai nicholaspai merged commit 31457a7 into mrice32/base-bridge-adapter Aug 11, 2023
2 checks passed
mrice32 added a commit that referenced this pull request Aug 18, 2023
* feat: add Base constants/defaults

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

* feat: add Base bridge adapter

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

* WIP

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

* feat: Add ZkSync function to AtomicWethDepositor (#875)

* feat: Add ZkSync function to AtomicWethDepositor

* Update AtomicWethDepositor.sol

* Update AtomicWethDepositor.sol

* Update AtomicWethDepositor.sol

* Update AtomicWethDepositor.sol

* Update AtomicWethDepositor.sol

* Update AtomicWethDepositor.sol

* Update src/clients/bridges/OpStackAdapter.ts

Co-authored-by: nicholaspai <9457025+nicholaspai@users.noreply.github.com>

* new deployment

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

* lint

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

* WIP

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

* updated deployment with Nick's fix

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

* lint

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

* update address

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

* WIP

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

* Update contracts/AtomicWethDepositor.sol

Co-authored-by: James Morris, MS <96435344+james-a-morris@users.noreply.github.com>

* Update AtomicWethDepositor.sol

* inherit optimism adapter

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

* lint

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

* WIP

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

* lint

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

* WIP

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

* WIP

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

* WIP

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

* WIP

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

* restructured

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

* WIP

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

* fix

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

* WIP

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>

---------

Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
Co-authored-by: nicholaspai <9457025+nicholaspai@users.noreply.github.com>
Co-authored-by: James Morris, MS <96435344+james-a-morris@users.noreply.github.com>
Co-authored-by: nicholaspai <npai.nyc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants