-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ZkSync function to AtomicWethDepositor #875
Merged
nicholaspai
merged 7 commits into
mrice32/base-bridge-adapter
from
npai/atomic-depositor-zksync
Aug 11, 2023
Merged
feat: Add ZkSync function to AtomicWethDepositor #875
nicholaspai
merged 7 commits into
mrice32/base-bridge-adapter
from
npai/atomic-depositor-zksync
Aug 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholaspai
requested review from
mrice32,
pxrl and
james-a-morris
as code owners
August 11, 2023 14:57
ACX-1421 use AtomicWethDepositor to bridge ETH
Currently the inventory manager adapter atomically (1) unwraps WETH and (2) bridges ETH but we can save gas by using a custom contract similar to how we do so for Polygon, and OVM chains https://github.com/across-protocol/relayer-v2/pull/874/files |
mrice32
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
mrice32
added a commit
that referenced
this pull request
Aug 18, 2023
* feat: add Base constants/defaults Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * feat: add Base bridge adapter Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * WIP Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * feat: Add ZkSync function to AtomicWethDepositor (#875) * feat: Add ZkSync function to AtomicWethDepositor * Update AtomicWethDepositor.sol * Update AtomicWethDepositor.sol * Update AtomicWethDepositor.sol * Update AtomicWethDepositor.sol * Update AtomicWethDepositor.sol * Update AtomicWethDepositor.sol * Update src/clients/bridges/OpStackAdapter.ts Co-authored-by: nicholaspai <9457025+nicholaspai@users.noreply.github.com> * new deployment Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * lint Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * WIP Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * updated deployment with Nick's fix Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * lint Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * update address Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * WIP Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * Update contracts/AtomicWethDepositor.sol Co-authored-by: James Morris, MS <96435344+james-a-morris@users.noreply.github.com> * Update AtomicWethDepositor.sol * inherit optimism adapter Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * lint Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * WIP Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * lint Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * WIP Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * WIP Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * WIP Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * WIP Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * restructured Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * WIP Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * fix Signed-off-by: Matt Rice <matthewcrice32@gmail.com> * WIP Signed-off-by: Matt Rice <matthewcrice32@gmail.com> --------- Signed-off-by: Matt Rice <matthewcrice32@gmail.com> Co-authored-by: nicholaspai <9457025+nicholaspai@users.noreply.github.com> Co-authored-by: James Morris, MS <96435344+james-a-morris@users.noreply.github.com> Co-authored-by: nicholaspai <npai.nyc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves ACX-1421