Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove UMA interfaces lookup #959

Merged
merged 5 commits into from
Sep 29, 2023
Merged

refactor: Remove UMA interfaces lookup #959

merged 5 commits into from
Sep 29, 2023

Conversation

pxrl
Copy link
Contributor

@pxrl pxrl commented Sep 29, 2023

These names change very rarely, and we only have need for a small number of the complete set.

These names change very rarely, and we only have need for a small number
of the complete set.
Copy link
Member

@nicholaspai nicholaspai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@james-a-morris can you look at this and make sure we don't overwrite this in the SDK changes?

@pxrl
Copy link
Contributor Author

pxrl commented Sep 29, 2023

@james-a-morris can you look at this and make sure we don't overwrite this in the SDK changes?

Ah good call, maybe this is migrated to sdk anyway.

Copy link
Contributor

@mrice32 mrice32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pxrl referenced this pull request in across-protocol/sdk Sep 29, 2023
Originally proposed to relayer-v2.
@pxrl
Copy link
Contributor Author

pxrl commented Sep 29, 2023

Part of this PR will be moved to sdk-v2, so I have re-proposed that part here: across-protocol/sdk#417.

Copy link
Contributor

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this is now reflected in the SDK

@pxrl pxrl merged commit 2da16b5 into master Sep 29, 2023
2 checks passed
@pxrl pxrl deleted the pxrl/interfaces branch September 29, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants