-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove UMA interfaces lookup #959
Conversation
These names change very rarely, and we only have need for a small number of the complete set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@james-a-morris can you look at this and make sure we don't overwrite this in the SDK changes?
Ah good call, maybe this is migrated to sdk anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Originally proposed to relayer-v2.
Part of this PR will be moved to sdk-v2, so I have re-proposed that part here: across-protocol/sdk#417. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - this is now reflected in the SDK
These names change very rarely, and we only have need for a small number of the complete set.