feat: Add helper methods for usage in Dataworker #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For preparing v3 SpokePoolClient functionality in advance of bumping contracts-v2.
This PR just shuffles some existing types around to make room for the new v3 types. It also introduces some convenience functions that will be useful for discriminating between v2 and v3 types, as well as extracting data from them. No functional change intended.
This change makes some non-functional refactoring to the SpokePoolClient to make it easier to introduce the support for v3. Doing it now just reduces the size and complexity of the subsequent diff.
Also update existing naming to map 1:1 onto their underlying SpokePool functions.
Suggested by James. Co-authored-by: James Morris, MS <96435344+james-a-morris@users.noreply.github.com>
Upgrade the various RelayData-dependent functions to work with v3 types. This will importantly be used for slow fill requests in the pending v3 bump.
Introduced unintentionally in the previous commit, this prevents parallel test execution and suppresses all other tests from running.
pxrl
reviewed
Feb 15, 2024
pxrl
reviewed
Feb 15, 2024
pxrl
reviewed
Feb 15, 2024
pxrl
reviewed
Feb 15, 2024
pxrl
reviewed
Feb 15, 2024
pxrl
reviewed
Feb 15, 2024
pxrl
reviewed
Feb 15, 2024
pxrl
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
OK subject to a conclusion on this one: https://github.com/across-protocol/sdk-v2/pull/535/files#r1491058411
This reverts commit bef6e15.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For usage in BundleDataClient