feat: Update to contracts-v2@2.5.0 #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 9, 2024
pxrl
approved these changes
Feb 11, 2024
There was a problem hiding this comment.
@nicholaspai I pushed some changes to this PR, specifically to:
- Update the fill utility functions to work only with v3 types.
- Complete the v3 fill status test (was previously @todo) and deprecated the v2 fill status test (will never be used).
- Add depositV3() and fillV3Relay() utility functions.
It's probably still my preference to import v3 contracts separately as an aliased package, but I don't have any reason to think that this approach won't work, and I am really satisfied to be able to test against v3 contracts in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes advantage of an updated MockSpokePool and updated test-utils exports from the contracts-v2 repo that make existing unit tests in this repo pass out of the box