-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(arweave): add arweave client for persisting/retrieving data #547
feat(arweave): add arweave client for persisting/retrieving data #547
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍 Left two small nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't have to be in this PR, but what are your thoughts on:
- catching out of fees errors
- handling file organization so we can aggregate files posted by the dataworker easily
We have custom tags now via (578f74c). Because Arweave is tangential from our normal day-to-day blockchain interactions, I'd think we should put a balance check in the monitor and dump that to slack if it gets close to zero. |
it is tangential but it has the ability to stop operations if we run out of arweave gas and either page us until we fill up gas or propose a bundle silently without posting to arweave |
No description provided.