refactor: Cleanup test import/exports #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primarily, avoid re-exporting the entirety of contracts-v2 from multiple places in the test directory. Additionally, re-organise so that test/constants only exports actual constants and not utility functions, then relocate the functions to test/utils/utils.ts.
nicholaspai
reviewed
Feb 12, 2024
nicholaspai
approved these changes
Feb 12, 2024
I'd say we're just making the dependencies explicit, rather than implicit. One of the drivers for this PR was me being unhappy with users importing from test/constants implicitly picking up dependencies from In future we should probably refine this further by forcing the user to just import contractsV2Utils.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily, avoid re-exporting the entirety of contracts-v2 from multiple places in the test directory. This gives better control over what is imported, and where from. Additionally, re-organise so that test/constants only exports actual constants and not utility functions, then relocate the functions to test/utils/utils.ts.